mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-11-08 20:40:59 +01:00
Code Issues Projects Releases Wiki Activity

OPTIM: quic: adjust automatic ALPN setting for QUIC servers

Browse Source 
If a QUIC server is declared without ALPN, "h3" value is automatically
set during _srv_parse_finalize().

This patch adjusts this operation. Instead of relying on
ssl_sock_parse_alpn(), a plain strdup() is used. This is considered more
efficient as the ALPN string is constant in this case. This method is
already used for listeners on the frontend side.
This commit is contained in:
Amaury Denoyelle 2025-10-31 10:12:55 +01:00
parent 14a6468df5
commit 73b5d331cc
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/configuration.txt
View File

@ -17696,7 +17696,9 @@ alpn <protocols>
delimited list of protocol names, for instance: "http/1.1,http/1.0" (without
quotes). This requires that the SSL library is built with support for TLS
extensions enabled (check with haproxy -vv). The ALPN extension replaces the
initial NPN extension. ALPN is required to connect to HTTP/2 servers.
initial NPN extension. ALPN is required to connect to HTTP/2 servers. It is
also required to be able to use HTTP/3 via a QUIC server, "h3" serves as a
default value for QUIC servers without "alpn" setting.
Versions of OpenSSL prior to 1.0.2 didn't support ALPN and only supposed the
now obsolete NPN extension.
If both HTTP/2 and HTTP/1.1 are expected to be supported, both versions can

9
src/server.c
View File

@ -3935,11 +3935,14 @@ static int _srv_parse_finalize(char **args, int cur_arg,
ha_warning("QUIC protocol detected, enabling ssl. Use 'ssl' to shut this warning.\n");
}
if (!srv->ssl_ctx.alpn_str &&
ssl_sock_parse_alpn("h3", &srv->ssl_ctx.alpn_str,
&srv->ssl_ctx.alpn_len, &errmsg) != 0) {
if (!srv->ssl_ctx.alpn_str) {
srv->ssl_ctx.alpn_str = strdup("\002h3");
if (!srv->ssl_ctx.alpn_str) {
ha_alert("out of memory while trying to allocate a default alpn string.\n");
return ERR_ALERT | ERR_FATAL;
}
srv->ssl_ctx.alpn_len = strlen(srv->ssl_ctx.alpn_str);
}
#else
ha_alert("QUIC protocol selected but support not compiled in (check build options).\n");
return ERR_ALERT | ERR_FATAL;