mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-08-07 07:37:02 +02:00
BUG/MINOR: tools: seed the statistical PRNG slightly better
Thomas Baroux reported a very interesting issue. "balance random" would systematically assign the same server first upon restart. That comes from its use of statistical_prng() which is only seeded with the thread number, and since at low loads threads are assigned to incoming connections in round robin order, practically speaking, the same thread always gets the same request and will produce the same random number. We already have a much better RNG that's also way more expensive, but we can use it at boot time to seed the PRNG instead of using the thread ID only. This needs to be backported to 2.4.
This commit is contained in:
parent
31ec9f18bb
commit
7151076522
@ -6333,7 +6333,7 @@ void *dlopen(const char *filename, int flags)
|
||||
static int init_tools_per_thread()
|
||||
{
|
||||
/* Let's make each thread start from a different position */
|
||||
statistical_prng_state += tid * MAX_THREADS;
|
||||
statistical_prng_state += ha_random32();
|
||||
if (!statistical_prng_state)
|
||||
statistical_prng_state++;
|
||||
return 1;
|
||||
|
Loading…
Reference in New Issue
Block a user