From 6d4890cfeaeac2983406ad544fde64400a1361a0 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Mon, 18 Nov 2013 18:04:25 +0100 Subject: [PATCH] BUG/MEDIUM: http: fix possible parser crash when parsing erroneous "http-request redirect" rules Baptiste Assmann reported a bug affecting the "http-request redirect" parser. It may randomly crash when reporting an error message if the syntax is not OK. It happens that this is caused by the output error message pointer which was not initialized to NULL. This bug is 1.5-specific (introduced in dev17), no backport is needed. --- src/proto_http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/proto_http.c b/src/proto_http.c index e82516734..f037b1edd 100644 --- a/src/proto_http.c +++ b/src/proto_http.c @@ -8491,7 +8491,7 @@ struct http_req_rule *parse_http_req_cond(const char **args, const char *file, i cur_arg += 2; } else if (strcmp(args[0], "redirect") == 0) { struct redirect_rule *redir; - char *errmsg; + char *errmsg = NULL; if ((redir = http_parse_redirect_rule(file, linenum, proxy, (const char **)args + 1, &errmsg)) == NULL) { Alert("parsing [%s:%d] : error detected in %s '%s' while parsing 'http-request %s' rule : %s.\n",