mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-05-07 05:56:09 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: quic: Missing random bits in Retry packet header

Browse Source 
The 4 bits least significant bits of the first byte in a Retry packet must be
random. There are generated calling statistical_prng_range() with 16 as argument.

Must be backported as far as 2.6.
This commit is contained in:
Frédéric Lécaille 2023-06-30 12:17:36 +02:00
parent bce0ca696c
commit 6c9bf2bdf5
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/quic_conn.c
View File

@ -6641,9 +6641,10 @@ static int send_retry(int fd, struct sockaddr_storage *addr,
TRACE_ENTER(QUIC_EV_CONN_TXPKT);
/* long header + fixed bit + packet type QUIC_PACKET_TYPE_RETRY */
/* long header(1) | fixed bit(1) | packet type QUIC_PACKET_TYPE_RETRY(2) | unused random bits(4)*/
buf[i++] = (QUIC_PACKET_LONG_HEADER_BIT | QUIC_PACKET_FIXED_BIT) |
(quic_pkt_type(QUIC_PACKET_TYPE_RETRY, qv->num) << QUIC_PACKET_TYPE_SHIFT);
(quic_pkt_type(QUIC_PACKET_TYPE_RETRY, qv->num) << QUIC_PACKET_TYPE_SHIFT) |
statistical_prng_range(16);
/* version */
buf[i++] = *((unsigned char *)&qv->num + 3);
buf[i++] = *((unsigned char *)&qv->num + 2);