From 6c54d8b63b291bfffd232214e65c6b05312c33ec Mon Sep 17 00:00:00 2001 From: Simon Horman Date: Fri, 15 Jul 2011 13:14:06 +0900 Subject: [PATCH] [MINOR] Consistently use error in tcp_parse_tcp_req() It seems to me that without this change tcp_parse_tcp_req() may leak memory. --- src/proto_tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/proto_tcp.c b/src/proto_tcp.c index cdaf15032..3b6d39d38 100644 --- a/src/proto_tcp.c +++ b/src/proto_tcp.c @@ -1213,7 +1213,7 @@ static int tcp_parse_tcp_req(char **args, int section_type, struct proxy *curpx, if (!(curpx->cap & PR_CAP_FE)) { snprintf(err, errlen, "%s %s is not allowed because %s %s is not a frontend", args[0], args[1], proxy_type_str(curpx), curpx->id); - return -1; + goto error; } if (tcp_parse_request_rule(args, arg, section_type, curpx, defpx, rule, err, errlen) < 0)