mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-22 06:11:32 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: mux-h2: do not report available outgoing streams after GOAWAY

Browse Source 
The calculation of available outgoing H2 streams was improved by commit
d64a3ebe6 ("BUG/MINOR: mux-h2: always check the stream ID limit in
h2_avail_streams()"), but it still is incorrect because RFC7540#6.8
specifically forbids the creation of new streams after a GOAWAY frame
was received. Thus we must not mark the connection as available anymore
in order to be able to handle a graceful shutdown.

This needs to be backported to 1.9.
This commit is contained in:
Willy Tarreau 2019-01-28 06:40:19 +01:00
parent 888d5678f7
commit 6afec46ba3
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mux_h2.c
View File

@ -415,6 +415,12 @@ static int h2_avail_streams(struct connection *conn)
struct h2c *h2c = conn->ctx; struct h2c *h2c = conn->ctx;
int ret1, ret2; int ret1, ret2;
/* RFC7540#6.8: Receivers of a GOAWAY frame MUST NOT open additional
* streams on the connection.
*/
if (h2c->last_sid >= 0)
return 0;
/* XXX Should use the negociated max concurrent stream nb instead of the conf value */ /* XXX Should use the negociated max concurrent stream nb instead of the conf value */
ret1 = h2_settings_max_concurrent_streams - h2c->nb_streams; ret1 = h2_settings_max_concurrent_streams - h2c->nb_streams;