From 655a7bcac15f5718d81ace99c988288e0df98014 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Mon, 6 Feb 2023 18:06:14 +0100 Subject: [PATCH] BUG/MEDIUM: listener/thread: bypass shards setting on failed thread resolution MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Aurélien reported that the BUG_ON(!new_ts.nbgrp) added in 2.8-dev3 by commit 50440457e ("MEDIUM: config: restrict shards, not bind_conf to one group each") can trigger on some invalid configs where the thread_set on the "bind" line couldn't be resolved. The reason is that we still enter the parsing loop (as it was done previously) and we possibly have no group to work on (which was the purpose of this assertion). There we need to bypass all this block on such a condition. No backport is needed. --- src/cfgparse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cfgparse.c b/src/cfgparse.c index 2788d6701..52b308697 100644 --- a/src/cfgparse.c +++ b/src/cfgparse.c @@ -2959,6 +2959,7 @@ init_proxies_list_stage1: curproxy->id, err, bind_conf->arg, bind_conf->file, bind_conf->line); free(err); cfgerr++; + continue; } /* apply thread masks and groups to all receivers */