mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-03-14 11:31:59 +01:00
Code Issues Projects Releases Wiki Activity

MINOR: quic: add BUG_ON() on half_open_conn counter access from BE

Browse Source 
half_open_conn is a proxy counter used to account for quic_conn in
half-open state : this represents a connection whose address is not yet
validated (handshake successful, or via token validation).

This counter only has sense for the frontend side. Currently, code is
safe as access is only performed if quic_conn is not yet flagged with
QUIC_FL_CONN_PEER_VALIDATED_ADDR, which is always set for backend
connections.

To better reflect this, add a BUG_ON() when half_open_conn is
incremented/decremented to ensure this never occurs for backend
connections.
This commit is contained in:
Amaury Denoyelle 2026-02-20 11:05:40 +01:00
parent b8cb8e1a65
commit 5f26cf162c
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/quic_conn.c
View File

@ -1665,7 +1665,8 @@ int quic_conn_release(struct quic_conn *qc)
/* Connection released before peer address validated. */
if (unlikely(!(qc->flags & QUIC_FL_CONN_PEER_VALIDATED_ADDR))) {
BUG_ON(!qc->prx_counters->half_open_conn);
/* half_open_conn counter must not be manipulated by BE conns. */
BUG_ON(qc_is_back(qc) || !qc->prx_counters->half_open_conn);
HA_ATOMIC_DEC(&qc->prx_counters->half_open_conn);
}

3
src/quic_rx.c
View File

@ -1357,7 +1357,8 @@ int qc_treat_rx_pkts(struct quic_conn *qc)
TRACE_STATE("validate peer address on handshake packet",
QUIC_EV_CONN_RXPKT, qc, pkt);
qc->flags |= QUIC_FL_CONN_PEER_VALIDATED_ADDR;
BUG_ON(!qc->prx_counters->half_open_conn);
/* half_open_conn counter must not be manipulated by BE conns. */
BUG_ON(qc_is_back(qc) || !qc->prx_counters->half_open_conn);
HA_ATOMIC_DEC(&qc->prx_counters->half_open_conn);
}