mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-24 07:11:20 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: cli: do not call the release handler on internal error.

Browse Source 
It's dangerous to call this on internal state error, because it risks
to perform a double-free. This can only happen when a state is not
handled. Note that the switch/case currently doesn't offer any option
for missed states since they're all declared. Better fix this anyway.
The fix was tested by commenting out some entries in the switch/case.
This commit is contained in:
Willy Tarreau 2015-09-25 20:08:51 +02:00
parent c9e930accc
commit 5cfa3bcc22
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/dumpstats.c
View File

@ -2554,8 +2554,7 @@ static void cli_io_handler(struct appctx *appctx)
break;
#endif
default: /* abnormal state */
cli_release_handler(appctx);
appctx->st0 = STAT_CLI_PROMPT;
si->flags |= SI_FL_ERR;
break;
}