From 5732062cd23ba26e31254fe9f86040467afbff1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Wed, 29 Dec 2021 16:00:47 +0100 Subject: [PATCH] MINOR: quic: Useless test in qc_prep_pkts() These tests were there to initiate PTO probing but they are not correct. Furthermore they may break the PTO probing process and lead to useless packet building. --- src/xprt_quic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/xprt_quic.c b/src/xprt_quic.c index 5dd977db2..ae32e82e0 100644 --- a/src/xprt_quic.c +++ b/src/xprt_quic.c @@ -2497,8 +2497,7 @@ static int qc_prep_pkts(struct quic_conn *qc, struct qring *qr) * select the next level. */ if ((tel == QUIC_TLS_ENC_LEVEL_INITIAL || tel == QUIC_TLS_ENC_LEVEL_HANDSHAKE) && - (MT_LIST_ISEMPTY(&qel->pktns->tx.frms) || - (next_tel != QUIC_TLS_ENC_LEVEL_NONE && qc->els[next_tel].pktns->tx.in_flight))) { + (MT_LIST_ISEMPTY(&qel->pktns->tx.frms))) { /* If QUIC_TLS_ENC_LEVEL_HANDSHAKE was already reached let's try QUIC_TLS_ENC_LEVEL_APP */ if (tel == QUIC_TLS_ENC_LEVEL_HANDSHAKE && next_tel == tel) next_tel = QUIC_TLS_ENC_LEVEL_APP;