mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-08-07 15:47:01 +02:00
MINOR: stick-table: store a per-table hash seed and use it
Instead of using memcpy() to concatenate the table's name to the key when allocating an stksess, let's compute once for all a per-table seed at boot time and use it to calculate the key's hash. This saves two memcpy() and the usage of a chunk, it's always nice in a fast path. When tested under extreme conditions with a 80-byte long table name, it showed a 1% performance increase.
This commit is contained in:
parent
63b5b33ba8
commit
56460ee52a
@ -174,6 +174,7 @@ struct stktable {
|
|||||||
pending for sync */
|
pending for sync */
|
||||||
unsigned int refcnt; /* number of local peer over all peers sections
|
unsigned int refcnt; /* number of local peer over all peers sections
|
||||||
attached to this table */
|
attached to this table */
|
||||||
|
uint64_t hash_seed; /* hash seed used by shards */
|
||||||
union {
|
union {
|
||||||
struct peers *p; /* sync peers */
|
struct peers *p; /* sync peers */
|
||||||
char *name;
|
char *name;
|
||||||
|
@ -164,22 +164,14 @@ static unsigned long long stksess_getkey_hash(struct stktable *t,
|
|||||||
struct stksess *ts,
|
struct stksess *ts,
|
||||||
struct stktable_key *key)
|
struct stktable_key *key)
|
||||||
{
|
{
|
||||||
struct buffer *buf;
|
|
||||||
size_t keylen;
|
size_t keylen;
|
||||||
|
|
||||||
/* Copy the stick-table id into <buf> */
|
|
||||||
buf = get_trash_chunk();
|
|
||||||
memcpy(b_tail(buf), t->id, t->idlen);
|
|
||||||
b_add(buf, t->idlen);
|
|
||||||
/* Copy the key into <buf> */
|
|
||||||
if (t->type == SMP_T_STR)
|
if (t->type == SMP_T_STR)
|
||||||
keylen = key->key_len;
|
keylen = key->key_len;
|
||||||
else
|
else
|
||||||
keylen = t->key_size;
|
keylen = t->key_size;
|
||||||
memcpy(b_tail(buf), key->key, keylen);
|
|
||||||
b_add(buf, keylen);
|
|
||||||
|
|
||||||
return XXH64(b_head(buf), b_data(buf), 0);
|
return XXH64(key->key, keylen, t->hash_seed);
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
@ -733,6 +725,9 @@ struct task *process_table_expire(struct task *task, void *context, unsigned int
|
|||||||
int stktable_init(struct stktable *t)
|
int stktable_init(struct stktable *t)
|
||||||
{
|
{
|
||||||
int peers_retval = 0;
|
int peers_retval = 0;
|
||||||
|
|
||||||
|
t->hash_seed = XXH64(t->id, t->idlen, 0);
|
||||||
|
|
||||||
if (t->size) {
|
if (t->size) {
|
||||||
t->keys = EB_ROOT_UNIQUE;
|
t->keys = EB_ROOT_UNIQUE;
|
||||||
memset(&t->exps, 0, sizeof(t->exps));
|
memset(&t->exps, 0, sizeof(t->exps));
|
||||||
|
Loading…
Reference in New Issue
Block a user