From 561958c17c47e6891a258eeaf77a8ff228f7b6d2 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Wed, 6 Oct 2021 19:36:47 +0200 Subject: [PATCH] CLEANUP: time: move a few configurable defines to defaults.h TV_ETERNITY, TV_ETERNITY_MS and MAX_DELAY_MS may be configured and ought to be in defaults.h so that they can be inherited from everywhere without including time.h and could also be redefined if neede (particularly for MAX_DELAY_MS). --- include/haproxy/defaults.h | 17 +++++++++++++++++ include/haproxy/time.h | 16 ---------------- 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/include/haproxy/defaults.h b/include/haproxy/defaults.h index 7547a17da..a6337e9c3 100644 --- a/include/haproxy/defaults.h +++ b/include/haproxy/defaults.h @@ -167,6 +167,23 @@ #define MAX_POLL_EVENTS 200 #endif +/* eternity when exprimed in timeval */ +#ifndef TV_ETERNITY +#define TV_ETERNITY (~0UL) +#endif + +/* eternity when exprimed in ms */ +#ifndef TV_ETERNITY_MS +#define TV_ETERNITY_MS (-1) +#endif + +/* we want to be able to detect time jumps. Fix the maximum wait time to a low + * value so that we know the time has changed if we wait longer. + */ +#ifndef MAX_DELAY_MS +#define MAX_DELAY_MS 60000 +#endif + // The maximum number of connections accepted at once by a thread for a single // listener. It used to default to 64 divided by the number of processes but // the tasklet-based model is much more scalable and benefits from smaller diff --git a/include/haproxy/time.h b/include/haproxy/time.h index bcba0f8f9..d1f181c7b 100644 --- a/include/haproxy/time.h +++ b/include/haproxy/time.h @@ -27,24 +27,8 @@ #include #include -/* eternity when exprimed in timeval */ -#ifndef TV_ETERNITY -#define TV_ETERNITY (~0UL) -#endif - -/* eternity when exprimed in ms */ -#ifndef TV_ETERNITY_MS -#define TV_ETERNITY_MS (-1) -#endif - #define TIME_ETERNITY (TV_ETERNITY_MS) -/* we want to be able to detect time jumps. Fix the maximum wait time to a low - * value so that we know the time has changed if we wait longer. - */ -#define MAX_DELAY_MS 60000 - - /* returns the lowest delay amongst and , and respects TIME_ETERNITY */ #define MINTIME(old, new) (((new)<0)?(old):(((old)<0||(new)<(old))?(new):(old))) #define SETNOW(a) (*a=now)