From 4d179ebd21b768bffee9cb28baa81a517dd7ac50 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cyril=20Bont=C3=A9?= Date: Fri, 23 Jul 2010 18:59:11 +0200 Subject: [PATCH] [BUG] stats: session rate limit gets garbaged in the stats The statistics page (the HTML one) displays a garbage value on frontends using "rate-limit session" in HTTP mode. This is due to the usage of the same buffer for the macros converting the max session rate and the limit. Steps to reproduce : Configuration file example : listen bug :80 mode http rate-limit sessions stats enable Then start refreshing the statistics page. This bug was introduced just before the release of haproxy 1.4.0. (was commit 6cfaf9e91969c87a9eab1d58a15d2d0a3f346c9b in 1.4) --- src/dumpstats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dumpstats.c b/src/dumpstats.c index 526e0f575..f8ba702e3 100644 --- a/src/dumpstats.c +++ b/src/dumpstats.c @@ -1601,7 +1601,7 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri) read_freq_ctr(&px->fe_req_per_sec), U2H0(read_freq_ctr(&px->fe_sess_per_sec)), px->counters.fe_rps_max, - U2H2(px->counters.fe_sps_max), + U2H1(px->counters.fe_sps_max), LIM2A2(px->fe_sps_lim, "-")); } else { chunk_printf(&msg,