diff --git a/src/ssl_sock.c b/src/ssl_sock.c index 65d0c857d..91e7dffa8 100644 --- a/src/ssl_sock.c +++ b/src/ssl_sock.c @@ -3639,6 +3639,8 @@ static int ssl_sock_load_dh_params(SSL_CTX *ctx, const struct ckch_data *data, * ERR_FATAL in any fatal error case * ERR_ALERT if the reason of the error is available in err * ERR_WARN if a warning is available into err + * The caller is responsible of freeing the newly built or newly refcounted + * find_chain element. * The value 0 means there is no error nor warning and * the operation succeed. */ @@ -3664,13 +3666,13 @@ static int ssl_sock_load_cert_chain(const char *path, const struct ckch_data *da } if (data->chain) { - *find_chain = data->chain; + *find_chain = X509_chain_up_ref(data->chain); } else { /* Find Certificate Chain in global */ struct issuer_chain *issuer; issuer = ssl_get0_issuer_chain(data->cert); if (issuer) - *find_chain = issuer->chain; + *find_chain = X509_chain_up_ref(issuer->chain); } if (!*find_chain) { @@ -3691,14 +3693,11 @@ static int ssl_sock_load_cert_chain(const char *path, const struct ckch_data *da #else { /* legacy compat (< openssl 1.0.2) */ X509 *ca; - STACK_OF(X509) *chain; - chain = X509_chain_up_ref(*find_chain); - while ((ca = sk_X509_shift(chain))) + while ((ca = sk_X509_shift(*find_chain))) if (!SSL_CTX_add_extra_chain_cert(ctx, ca)) { memprintf(err, "%sunable to load chain certificate into SSL Context '%s'.\n", err && *err ? *err : "", path); X509_free(ca); - sk_X509_pop_free(chain, X509_free); errcode |= ERR_ALERT | ERR_FATAL; goto end; } @@ -3791,6 +3790,7 @@ static int ssl_sock_put_ckch_into_ctx(const char *path, const struct ckch_data * #endif end: + sk_X509_pop_free(find_chain, X509_free); return errcode; } @@ -3828,6 +3828,7 @@ static int ssl_sock_put_srv_ckch_into_ctx(const char *path, const struct ckch_da } end: + sk_X509_pop_free(find_chain, X509_free); return errcode; }