mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 07:37:02 +02:00
Code Issues Projects Releases Wiki Activity

MEDIUM: clock: don't compute before_poll when using monotonic clock

Browse Source 
There's no point keeping both clocks up to date; if the monotonic clock
is ticking, let's just refrain from updating the wall clock one before
polling since we won't use it. We still do it after polling however as
we need a wall clock time to communicate with outside.

This saves one gettimeofday() call per loop and two timeval comparisons.
This commit is contained in:
Willy Tarreau 2024-09-08 19:03:30 +00:00
parent 24496803d1
commit 499e057644
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/clock.c
View File

@ -442,8 +442,6 @@ void clock_entering_poll(void)
uint32_t run_time;
int64_t stolen;
gettimeofday(&before_poll, NULL);
new_cpu_time = now_cpu_time();
new_mono_time = now_mono_time();
@ -461,15 +459,18 @@ void clock_entering_poll(void)
* too much wrong during such jumps.
*/
if (unlikely(__tv_islt(&before_poll, &after_poll)))
before_poll = after_poll;
else if (unlikely(__tv_ms_elapsed(&after_poll, &before_poll) >= 2000))
tv_ms_add(&before_poll, &after_poll, 2000);
if (before_poll_mono_ns)
run_time = (before_poll_mono_ns - th_ctx->curr_mono_time) / 1000ull;
else
else {
gettimeofday(&before_poll, NULL);
if (unlikely(__tv_islt(&before_poll, &after_poll)))
before_poll = after_poll;
else if (unlikely(__tv_ms_elapsed(&after_poll, &before_poll) >= 2000))
tv_ms_add(&before_poll, &after_poll, 2000);
run_time = (before_poll.tv_sec - after_poll.tv_sec) * 1000000U + (before_poll.tv_usec - after_poll.tv_usec);
}
if (th_ctx->prev_cpu_time && th_ctx->prev_mono_time) {
new_cpu_time -= th_ctx->prev_cpu_time;