mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-23 14:51:27 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: h1: Reject requests with different occurrences of the header host

Browse Source 
There is no reason for a client to send several headers host. It even may be
considered as a bug. However, it is totally invalid to have different values for
those. So now, in such case, an error is triggered during the request
parsing. In addition, when several headers host are found with the same value,
only the first instance is kept and others are skipped.
This commit is contained in:
Christopher Faulet 2019-10-11 09:01:44 +02:00
parent 486498c630
commit 497ab4f519
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/h1.c
View File

@ -282,6 +282,7 @@ int h1_headers_to_hdr_list(char *start, const char *stop,
union h1_sl sl; union h1_sl sl;
int skip_update; int skip_update;
int restarting; int restarting;
int host_idx;
struct ist n, v; /* header name and value during parsing */ struct ist n, v; /* header name and value during parsing */
skip = 0; // do it only once to keep track of the leading CRLF. skip = 0; // do it only once to keep track of the leading CRLF.
@ -290,6 +291,7 @@ int h1_headers_to_hdr_list(char *start, const char *stop,
hdr_count = sol = col = eol = sov = 0; hdr_count = sol = col = eol = sov = 0;
sl.st.status = 0; sl.st.status = 0;
skip_update = restarting = 0; skip_update = restarting = 0;
host_idx = -1;
if (h1m->flags & H1_MF_HDRS_ONLY) { if (h1m->flags & H1_MF_HDRS_ONLY) {
state = H1_MSG_HDR_FIRST; state = H1_MSG_HDR_FIRST;
@ -831,6 +833,18 @@ int h1_headers_to_hdr_list(char *start, const char *stop,
break; break;
} }
} }
else if (isteqi(n, ist("host"))) {
if (host_idx == -1)
host_idx = hdr_count;
else {
if (!isteqi(v, hdr[host_idx].v)) {
state = H1_MSG_HDR_L2_LWS;
goto http_msg_invalid;
}
/* if the same host, skip it */
break;
}
}
http_set_hdr(&hdr[hdr_count++], n, v); http_set_hdr(&hdr[hdr_count++], n, v);
} while (0); } while (0);