mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-21 22:01:31 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: mworker: only write to pidfile if it exists

Browse Source 
A missing test causes a write(-1, $PID) to appear in strace output when
in master-worker mode. This is totally harmless though.

This fix must be backported to 1.8.
This commit is contained in:
Willy Tarreau 2018-01-23 19:20:19 +01:00
parent 1605c7ae61
commit 46ec48bc1a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/haproxy.c
View File

@ -2786,7 +2786,8 @@ int main(int argc, char **argv)
if (global.mode & MODE_MWORKER) { if (global.mode & MODE_MWORKER) {
char pidstr[100]; char pidstr[100];
snprintf(pidstr, sizeof(pidstr), "%d\n", getpid()); snprintf(pidstr, sizeof(pidstr), "%d\n", getpid());
shut_your_big_mouth_gcc(write(pidfd, pidstr, strlen(pidstr))); if (pidfd >= 0)
shut_your_big_mouth_gcc(write(pidfd, pidstr, strlen(pidstr)));
} }
/* the father launches the required number of processes */ /* the father launches the required number of processes */