mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-11-24 20:31:00 +01:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: h2: match absolute-path not path-absolute for :path

Browse Source 
RFC7540 states that :path follows RFC3986's path-absolute. However
that was a bug introduced in the spec between draft 04 and draft 05
of the spec, which implicitly causes paths starting with "//" to be
forbidden. HTTP/1 (and now HTTP core semantics) made it explicit
that the request-target in origin-form follows a purposely defined
absolute-path defined as 1*(/ segment) to explicitly allow "//".

http2bis now fixes this by relying on absolute-path so that "//"
becomes valid and matches other versions. Full discussion here:

  https://lists.w3.org/Archives/Public/ietf-http-wg/2021JulSep/0245.html

This issue appeared in haproxy with commit 4b8852c70 ("BUG/MAJOR: h2:
verify that :path starts with a '/' before concatenating it") when
making the checks on :path fully comply with the spec, and was backported
as far as 2.0, so this fix must be backported there as well to allow
"//" in H2 again.
This commit is contained in:
Willy Tarreau 2021-08-19 23:06:58 +02:00
parent 74f6ab6e87
commit 46b7dff8f0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/h2.c
View File

@ -279,6 +279,9 @@ static struct htx_sl *h2_prepare_htx_reqline(uint32_t fields, struct ist *phdr,
/* 7540#8.1.2.3: :path must not be empty, and must be either /* 7540#8.1.2.3: :path must not be empty, and must be either
* '*' or an RFC3986 "path-absolute" starting with a "/" but * '*' or an RFC3986 "path-absolute" starting with a "/" but
* not with "//". * not with "//".
* However, this "path-absolute" was a mistake which was
* later fixed in http2bis as "absolute-path" to match
* HTTP/1, thus also allowing "//".
*/ */
if (unlikely(!phdr[H2_PHDR_IDX_PATH].len)) if (unlikely(!phdr[H2_PHDR_IDX_PATH].len))
goto fail; goto fail;
@ -286,9 +289,6 @@ static struct htx_sl *h2_prepare_htx_reqline(uint32_t fields, struct ist *phdr,
if (!isteq(phdr[H2_PHDR_IDX_PATH], ist("*"))) if (!isteq(phdr[H2_PHDR_IDX_PATH], ist("*")))
goto fail; goto fail;
} }
else if (phdr[H2_PHDR_IDX_PATH].len > 1 &&
phdr[H2_PHDR_IDX_PATH].ptr[1] == '/')
goto fail;
} }
if (!(flags & HTX_SL_F_HAS_SCHM)) { if (!(flags & HTX_SL_F_HAS_SCHM)) {