mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 15:47:01 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: stick-tables: fix the task's next expiration date

Browse Source 
While changing the stick-table indexing that led to commit 1a088da7c
("MAJOR: stktable: split the keys across multiple shards to reduce
contention"), I met a problem with the task's expiration date being
incorrectly updated, I fixed it and apparently I committed the wrong
version :-/

The effect is that the task's date is only correctly reset if the
table is empty, otherwise the task wakes up again and is queued at
the previous date, eating 100% CPU. The tick_isfirst() must not be
used when storing the last result.

No backport is needed as this was only merged in 3.0-dev7.
This commit is contained in:
Willy Tarreau 2024-04-12 09:57:32 +02:00
parent d308c9a9f6
commit 44a8f9e7fc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/stick_table.c
View File

@ -903,7 +903,7 @@ struct task *process_table_expire(struct task *task, void *context, unsigned int
* were to update with TICK_ETERNITY. * were to update with TICK_ETERNITY.
*/ */
HA_RWLOCK_WRLOCK(STK_TABLE_LOCK, &t->lock); HA_RWLOCK_WRLOCK(STK_TABLE_LOCK, &t->lock);
task->expire = tick_first(task->expire, task_exp); task->expire = task_exp;
HA_RWLOCK_WRUNLOCK(STK_TABLE_LOCK, &t->lock); HA_RWLOCK_WRUNLOCK(STK_TABLE_LOCK, &t->lock);
return task; return task;