From 4490df57a6d6d603077c1ecbb69c67a07bc9e3d6 Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Thu, 19 Dec 2024 16:34:18 +0100 Subject: [PATCH] CLEANUP: mux-quic: remove dead err label in qcc_build_frms() STREAM frames emission in qcc_build_frms() has been splitted from RESET_STREAM/STOP_SENDING into qcc_emit_rs_ss(). Now, the former cannot fail, as such err label can be removed as it is unreachable. This should be backported up to 3.1. This should fix github issue #2824. --- src/mux_quic.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/mux_quic.c b/src/mux_quic.c index 611c5dba2..e3fa05cb4 100644 --- a/src/mux_quic.c +++ b/src/mux_quic.c @@ -2443,11 +2443,6 @@ static int qcc_build_frms(struct qcc *qcc, struct list *qcs_failed) TRACE_LEAVE(QMUX_EV_QCC_SEND, qcc->conn); return total; - - err: - qcc_clear_frms(qcc); - TRACE_DEVEL("leaving on error", QMUX_EV_QCC_SEND, qcc->conn); - return 0; } /* Proceed to sending. Loop through all available streams for the