mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-09 16:47:18 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: quic: Useless TLS context allocations in qc_do_rm_hp()

Browse Source 
These allocations are definitively useless.

Must be backported to 2.7.
This commit is contained in:
Frédéric Lécaille 2023-03-07 10:28:16 +01:00 committed by Amaury Denoyelle
parent 8ac8a8778d
commit 433af7fad9
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/quic_conn.c
View File

@ -1449,7 +1449,6 @@ static int qc_do_rm_hp(struct quic_conn *qc,
uint32_t truncated_pn = 0; uint32_t truncated_pn = 0;
unsigned char mask[5] = {0}; unsigned char mask[5] = {0};
unsigned char *sample; unsigned char *sample;
EVP_CIPHER_CTX *cctx = NULL;
TRACE_ENTER(QUIC_EV_CONN_RMHP, qc); TRACE_ENTER(QUIC_EV_CONN_RMHP, qc);
@ -1461,12 +1460,6 @@ static int qc_do_rm_hp(struct quic_conn *qc,
goto leave; goto leave;
} }
cctx = EVP_CIPHER_CTX_new();
if (!cctx) {
TRACE_ERROR("memory allocation failed", QUIC_EV_CONN_RMHP, qc, pkt);
goto leave;
}
sample = pn + QUIC_PACKET_PN_MAXLEN; sample = pn + QUIC_PACKET_PN_MAXLEN;
if (!quic_tls_aes_decrypt(mask, sample, sizeof mask, tls_ctx->rx.hp_ctx)) { if (!quic_tls_aes_decrypt(mask, sample, sizeof mask, tls_ctx->rx.hp_ctx)) {
@ -1488,8 +1481,6 @@ static int qc_do_rm_hp(struct quic_conn *qc,
ret = 1; ret = 1;
leave: leave:
if (cctx)
EVP_CIPHER_CTX_free(cctx);
TRACE_LEAVE(QUIC_EV_CONN_RMHP, qc); TRACE_LEAVE(QUIC_EV_CONN_RMHP, qc);
return ret; return ret;
} }