mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 15:47:01 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: http-htx: add BUG_ON to prevent API error on http_cookie_register

Browse Source 
http_cookie_register() must be called on first invocation with the last
two arguments pointing both to a negative value. After it, they will be
updated to a valid index.

We must never have only the last argument as NULL as this will cause an
invalid array addressing. To clarify this a BUG_ON statement is
introduced.

This is linked to github issue #1967.
This commit is contained in:
Amaury Denoyelle 2022-12-15 09:27:34 +01:00
parent 8f1f1b0579
commit 4328b61bb3
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/http_htx.c
View File

@ -1817,6 +1817,11 @@ void http_cookie_register(struct http_hdr *list, int idx, int *first, int *last)
* the next one. The last entry will contains -1. * the next one. The last entry will contains -1.
*/ */
/* Caller is responsible to initialize *first and *last to -1 on first
* invocation. Both will thus be set to a valid index after it.
*/
BUG_ON(*first > 0 && *last < 0);
/* Mark the current end of cookie linked list. */ /* Mark the current end of cookie linked list. */
list[idx].n.len = -1; list[idx].n.len = -1;
if (*first < 0) { if (*first < 0) {