From 41a454da0a47e0d37e37f2d9a13712b7736e9cc5 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Tue, 28 Mar 2023 12:02:03 +0200 Subject: [PATCH] BUG/MINOR: stats: Don't replace sc_shutr() by SE_FL_EOS flag yet In commit c2c043ed4 ("BUG/MEDIUM: stats: Consume the request except when parsing the POST payload"), a change about applet was pushed too early. The applet must still call cf_shutr() when the response is fully sent. It is planned to rely on SE_FL_EOS flag, just like connections. But it is not possible for now. However, at first glance, this bug has no visible effect. It is 2.8-specific. No backport needed. --- src/stats.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/stats.c b/src/stats.c index edee3aaf5..3e1b90b1f 100644 --- a/src/stats.c +++ b/src/stats.c @@ -4506,7 +4506,8 @@ static void http_stats_io_handler(struct appctx *appctx) } if (appctx->st0 == STAT_HTTP_END) { - se_fl_set(appctx->sedesc, SE_FL_EOS); + if (!(res->flags & CF_SHUTR)) + sc_shutr(sc); applet_will_consume(appctx); }