mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-06 07:07:04 +02:00
Code Issues Projects Releases Wiki Activity

IMPORT: slz: use a better hash for machines with a fast multiply

Browse Source 
The current hash involves 3 simple shifts and additions so that it can
be mapped to a multiply on architecures having a fast multiply. This is
indeed what the compiler does on x86_64. A large range of values was
scanned to try to find more optimal factors on machines supporting such
a fast multiply, and it turned out that new factor 0x1af42f resulted in
smoother hashes that provided on average 0.4% better compression on both
the Silesia corpus and an mbox file composed of very compressible emails
and uncompressible attachments. It's even slightly better than CRC32C
while being faster on Skylake. This patch enables this factor on archs
with a fast multiply.

This is slz upstream commit 82ad1e75c13245a835c1c09764c89f2f6e8e2a40.
This commit is contained in:
Willy Tarreau 2023-04-09 11:50:15 +02:00
parent 248bbec83c
commit 411b04c7d3
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/import/slz.h
View File

@ -38,6 +38,7 @@
#define UNALIGNED_LE_OK
#define UNALIGNED_FASTER
#define USE_64BIT_QUEUE
#define HAVE_FAST_MULT
#elif defined(__i386__) || defined(__i486__) || defined(__i586__) || defined(__i686__)
#define UNALIGNED_LE_OK
//#define UNALIGNED_FASTER
@ -47,6 +48,7 @@
#elif defined(__ARM_ARCH_8A) || defined(__ARM_FEATURE_UNALIGNED)
#define UNALIGNED_LE_OK
#define UNALIGNED_FASTER
#define HAVE_FAST_MULT
#endif
/* Log2 of the size of the hash table used for the references table. */

3
src/slz.c
View File

@ -388,6 +388,9 @@ static inline uint32_t slz_hash(uint32_t a)
// but provides a slightly smoother hash
__asm__ volatile("crc32l %1,%0" : "+r"(a) : "r"(0));
return a >> (32 - HASH_BITS);
#elif defined(HAVE_FAST_MULT)
// optimal factor for HASH_BITS=12 and HASH_BITS=13 among 48k tested: 0x1af42f
return (a * 0x1af42f) >> (32 - HASH_BITS);
#else
return ((a << 19) + (a << 6) - a) >> (32 - HASH_BITS);
#endif