mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-05-01 11:10:59 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: debug: properly mark the entire libs archive read-only

Browse Source 
In 3.4-dev7, commit e1738b665d ("MINOR: debug: read all libs in memory
when set-dumpable=libs") reads dependencies into memory to store them as
a tar archive for later debugging. There was an attempt to mark the whole
archive read-only, except that the size passed in argument to mprotect()
is wrong: lib_size is only assigned after the operation and is still zero
at the moment this is done. new_size ought to be used instead.

This needs to be backported wherever the commit above is backported, at
least 3.2.
This commit is contained in:
Willy Tarreau 2026-04-23 13:52:33 +02:00
parent 3c63298acd
commit 4034f78fc4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tools.c
View File

@ -6137,7 +6137,7 @@ void collect_libs(void)
page += pagesize;
/* copy and make read-only */
memcpy(page, ctx.storage, ctx.size);
mprotect(page, lib_size, PROT_READ);
mprotect(page, new_size, PROT_READ);
vma_set_name(page, new_size, "archive", "boot-libs");
lib_storage = page;