mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-28 17:21:32 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: mux-h2: make sure the h2c task exists before refreshing it

Browse Source 
When detaching a stream, if it's the last one and the mbuf is blocked,
we leave without freeing the stream yet. We also refresh the h2c task's
timeout, except that it's possible that there's no such task in case
there is no client timeout, causing a crash. The fix just consists in
doing this when the task exists.

This bug has always been there and is extremely hard to meet even
without a client timeout. This fix has to be backported to all
branches, but it's unlikely anyone has ever met it anyay.
This commit is contained in:
Willy Tarreau 2023-03-16 18:06:19 +01:00
parent 3a7b539b12
commit 3fb2c6d5b4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mux_h2.c
View File

@ -4312,7 +4312,7 @@ static void h2_detach(struct sedesc *sd)
/* refresh the timeout if none was active, so that the last
* leaving stream may arm it.
*/
if (!tick_isset(h2c->task->expire))
if (h2c->task && !tick_isset(h2c->task->expire))
h2c_update_timeout(h2c);
return;
}