REORG: quic: Remove qc_pkt_insert() implementation

As this function does only a few things with a not very well chosen name,
remove it and replace it by the its statements at the unique location it
is called.
This commit is contained in:
Frédéric Lécaille 2023-11-28 14:52:22 +01:00
parent 95e9033fd2
commit 3e16784dfc

View File

@ -1412,19 +1412,6 @@ static inline int quic_packet_read_long_header(unsigned char **pos, const unsign
return ret; return ret;
} }
/* Insert <pkt> RX packet in its <qel> RX packets tree */
static void qc_pkt_insert(struct quic_conn *qc,
struct quic_rx_packet *pkt, struct quic_enc_level *qel)
{
TRACE_ENTER(QUIC_EV_CONN_RXPKT, qc);
pkt->pn_node.key = pkt->pn;
quic_rx_packet_refinc(pkt);
eb64_insert(&qel->rx.pkts, &pkt->pn_node);
TRACE_LEAVE(QUIC_EV_CONN_RXPKT, qc);
}
/* Try to remove the header protection of <pkt> QUIC packet with <beg> the /* Try to remove the header protection of <pkt> QUIC packet with <beg> the
* address of the packet first byte, using the keys from encryption level <el>. * address of the packet first byte, using the keys from encryption level <el>.
* *
@ -2128,8 +2115,12 @@ static void qc_rx_pkt_handle(struct quic_conn *qc, struct quic_rx_packet *pkt,
} }
TRACE_DATA("New packet", QUIC_EV_CONN_LPKT, qc, pkt, NULL, qv); TRACE_DATA("New packet", QUIC_EV_CONN_LPKT, qc, pkt, NULL, qv);
if (pkt->aad_len) if (pkt->aad_len) {
qc_pkt_insert(qc, pkt, qel); /* Insert this RX packet in its encryption level tree */
pkt->pn_node.key = pkt->pn;
quic_rx_packet_refinc(pkt);
eb64_insert(&qel->rx.pkts, &pkt->pn_node);
}
out: out:
*tasklist_head = tasklet_wakeup_after(*tasklist_head, *tasklist_head = tasklet_wakeup_after(*tasklist_head,
qc->wait_event.tasklet); qc->wait_event.tasklet);