mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 07:37:02 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: proto-tcp: Take care to initialized tcp_md5sig structure

Browse Source 
When the TCP MD5 signature is enabled, on a listening socket or an outgoing
one, the tcp_md5sig structure must be initialized first.

It is a 3.3-specific issue. No backport needed.
This commit is contained in:
Christopher Faulet 2025-07-04 08:32:05 +02:00
parent 45cb232062
commit 3cc5991c9b
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/proto_tcp.c
View File

@ -536,6 +536,7 @@ int tcp_connect_server(struct connection *conn, int flags)
if (srv && srv->tcp_md5sig) { if (srv && srv->tcp_md5sig) {
struct tcp_md5sig md5; struct tcp_md5sig md5;
memset(&md5, 0, sizeof(md5));
if (conn->dst->ss_family == AF_INET) if (conn->dst->ss_family == AF_INET)
memcpy(&md5.tcpm_addr, (struct sockaddr_in *)conn->dst, sizeof(struct sockaddr_in)); memcpy(&md5.tcpm_addr, (struct sockaddr_in *)conn->dst, sizeof(struct sockaddr_in));
else else
@ -735,6 +736,7 @@ int tcp_bind_listener(struct listener *listener, char *errmsg, int errlen)
if (listener->bind_conf->tcp_md5sig) { if (listener->bind_conf->tcp_md5sig) {
struct tcp_md5sig md5; struct tcp_md5sig md5;
memset(&md5, 0, sizeof(md5));
if (listener->rx.addr.ss_family == AF_INET) if (listener->rx.addr.ss_family == AF_INET)
memcpy(&md5.tcpm_addr, (struct sockaddr_in *)&listener->rx.addr, sizeof(struct sockaddr_in)); memcpy(&md5.tcpm_addr, (struct sockaddr_in *)&listener->rx.addr, sizeof(struct sockaddr_in));
else else