mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-10 09:07:02 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: quic: adjust request reject when MUX is already freed

Browse Source 
When the MUX is freed, the quic-conn layer may stay active until all
streams acknowledgment are processed. In this interval, if a new stream
is opened by the client, the quic-conn is thus now responsible to handle
it. This is done by the emission of a STOP_SENDING.

This process is closely related to HTTP/3 protocol despite being handled
by the quic-conn layer. This highlights a flaw in our QUIC architecture
which should be adjusted. To reflect this situation, the function
qc_stop_sending_frm_enqueue() is renamed qc_h3_request_reject(). Also,
internal H3 treatment such as uni-directional bypass has been moved
inside the function.

This commit is only a refactor. However, bug fix on next patches will
rely on it so it should be backported up to 2.6.
This commit is contained in:
Amaury Denoyelle 2023-02-07 14:24:54 +01:00
parent 5faf577997
commit 38836b6b3d
1 changed files with 21 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/quic_conn.c
View File

@ -2697,24 +2697,33 @@ static void qc_cc_err_count_inc(struct quic_conn *qc, struct quic_frame *frm)
TRACE_LEAVE(QUIC_EV_CONN_CLOSE, qc); TRACE_LEAVE(QUIC_EV_CONN_CLOSE, qc);
} }
/* Enqueue a STOP_SENDING frame to send into 1RTT packet number space /* Cancel a request on connection <qc> for stream id <id>. This is useful when
* frame list to send. * the client opens a new stream but the MUX has already been released. A
* Return 1 if succeeded, 0 if not. * STOP_SENDING frame is prepared for emission.
*
* TODO this function is closely related to H3. Its place should be in H3 layer
* instead of quic-conn but this requires an architecture adjustment.
*
* Returns 1 on sucess else 0.
*/ */
static int qc_stop_sending_frm_enqueue(struct quic_conn *qc, uint64_t id) static int qc_h3_request_reject(struct quic_conn *qc, uint64_t id)
{ {
int ret = 0; int ret = 0;
struct quic_frame *frm; struct quic_frame *frm;
struct quic_enc_level *qel = &qc->els[QUIC_TLS_ENC_LEVEL_APP]; struct quic_enc_level *qel = &qc->els[QUIC_TLS_ENC_LEVEL_APP];
uint64_t app_error_code; const uint64_t app_error_code = H3_REQUEST_REJECTED;
TRACE_ENTER(QUIC_EV_CONN_PRSHPKT, qc); TRACE_ENTER(QUIC_EV_CONN_PRSHPKT, qc);
/* TODO: the mux may be released, we cannot have more /* Do not emit rejection for unknown unidirectional stream as it is
* information about the application error code to send * forbidden to close some of them (H3 control stream and QPACK
* at this time. * encoder/decoder streams).
*/ */
app_error_code = H3_REQUEST_REJECTED; if (quic_stream_is_uni(id)) {
ret = 1;
goto out;
}
frm = qc_frm_alloc(QUIC_FT_STOP_SENDING); frm = qc_frm_alloc(QUIC_FT_STOP_SENDING);
if (!frm) { if (!frm) {
TRACE_ERROR("failed to allocate quic_frame", QUIC_EV_CONN_PRSHPKT, qc); TRACE_ERROR("failed to allocate quic_frame", QUIC_EV_CONN_PRSHPKT, qc);
@ -2935,19 +2944,10 @@ static int qc_parse_pkt_frms(struct quic_conn *qc, struct quic_rx_packet *pkt,
} }
else { else {
TRACE_DEVEL("No mux for new stream", QUIC_EV_CONN_PRSHPKT, qc); TRACE_DEVEL("No mux for new stream", QUIC_EV_CONN_PRSHPKT, qc);
if (qc->app_ops == &h3_ops && quic_stream_is_uni(stream->id)) { if (qc->app_ops == &h3_ops) {
/* Do not send STOP_SENDING frames for h3 unidirectional streams. if (!qc_h3_request_reject(qc, stream->id))
* TODO: this test should be removed when the connection closure TRACE_ERROR("could not enqueue STOP_SENDING frame", QUIC_EV_CONN_PRSHPKT, qc);
* will be more clean.
* At quic_conn level there is no mean to know that an application
* want to forbid stream closure requests to receivers. This is the
* case for the Control and QPACK h3 unidirectional streams.
*/
goto leave;
} }
if (!qc_stop_sending_frm_enqueue(qc, stream->id))
TRACE_ERROR("could not enqueue STOP_SENDING frame", QUIC_EV_CONN_PRSHPKT, qc);
/* This packet will not be acknowledged */ /* This packet will not be acknowledged */
goto leave; goto leave;
} }