mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-06 23:27:04 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: fd: Add BUG_ON checks on fd_insert()

Browse Source 
This patch adds two BUG_ON on fd_insert() into the fdtab checking
if the fd has been correctly re-initialized into the fdtab
before a new insert.

It will raise a BUG if we try to insert the same fd multiple times
without an intermediate fd_delete().

First one checks that the owner for this fd in fdtab was reset to NULL.

Second one checks that the state flags for this fd in fdtab was reset
to 0.

This patch could be backported on version >= 2.4
This commit is contained in:
Emeric Brun 2022-07-01 04:57:39 -07:00 committed by Willy Tarreau
parent 34aae2fd12
commit 36d9097cf3
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/haproxy/fd.h
View File

@ -332,6 +332,8 @@ static inline void fd_insert(int fd, void *owner, void (*iocb)(int fd), unsigned
* addition to overwriting some unexpected memory areas. * addition to overwriting some unexpected memory areas.
*/ */
BUG_ON(fd < 0 || fd >= global.maxsock); BUG_ON(fd < 0 || fd >= global.maxsock);
BUG_ON(fdtab[fd].owner != NULL);
BUG_ON(fdtab[fd].state != 0);
fdtab[fd].owner = owner; fdtab[fd].owner = owner;
fdtab[fd].iocb = iocb; fdtab[fd].iocb = iocb;