mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-01-30 06:22:00 +01:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: lb-chash: Fix the realloc() when the number of nodes is increased

Browse Source 
When the number of nodes is increased because the server weight is changed, the
nodes array must be realloc. But its new size is not correctly set. Only the
total number of nodes is used to set the new size. But it must also depends on
the size of a node. It must be the total nomber of nodes times the size of a
node.

This issue was reported on Github (#189).

This patch must be backported to all versions since the 1.6.
This commit is contained in:
Christopher Faulet 2019-07-26 13:52:13 +02:00
parent d6e0c03384
commit 366ad86af7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lb_chash.c
View File

@ -84,7 +84,7 @@ static inline void chash_queue_dequeue_srv(struct server *s)
* increased the weight beyond the original weight
*/
if (s->lb_nodes_tot < s->next_eweight) {
struct tree_occ *new_nodes = realloc(s->lb_nodes, s->next_eweight);
struct tree_occ *new_nodes = realloc(s->lb_nodes, s->next_eweight * sizeof(*new_nodes));
if (new_nodes) {
unsigned int j;