From 362d25e50708adf2b273bf9ee04f6566f113815e Mon Sep 17 00:00:00 2001 From: Emeric Brun Date: Wed, 10 Mar 2021 16:58:03 +0100 Subject: [PATCH] BUG/MEDIUM: stick-tables: fix ref counter in table entry using multiple http tracksc. Setting multiple http-request track-scX rules generates entries which never expires. If there was already an entry registered by a previous http rule 'stream_track_stkctr(&s->stkctr[rule->action], t, ts)' didn't register the new 'ts' into the stkctr. And function is left with no reference on 'ts' whereas refcount had been increased by the '_get_entry' The patch applies the same policy as the one showed on tcp track rules and if there is successive rules the track counter keep the first entry registered in the counter and nothing more is computed. After validation this should be backported in all versions. --- src/http_act.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/http_act.c b/src/http_act.c index b4aced17c..838deb52d 100644 --- a/src/http_act.c +++ b/src/http_act.c @@ -1784,6 +1784,10 @@ static enum act_return http_action_track_sc(struct act_rule *rule, struct proxy opt = ((rule->from == ACT_F_HTTP_REQ) ? SMP_OPT_DIR_REQ : SMP_OPT_DIR_RES) | SMP_OPT_FINAL; t = rule->arg.trk_ctr.table.t; + + if (stkctr_entry(&s->stkctr[rule->action])) + goto end; + key = stktable_fetch_key(t, s->be, sess, s, opt, rule->arg.trk_ctr.expr, NULL); if (!key)