mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-05-01 11:10:59 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: stats: fix crash on 'dump stats-file'

Browse Source 
A crash occurs immediately when stats-file dump is requested by the
command-line. The issue is caused by the introduction of watchers when
iterating over the proxies list, which is now required with dynamic
backends.

  commit 20376c54e2166a0882b71b26326360786f79ebdb
  MINOR: stats: protect proxy iteration via watcher

The above patch initializes the new proxy watcher for stats dump and
HTML. However, this was forgotten for stats-file command context. Fix
this by adding the missing watcher_init() in cli_parse_show_stat().

No need to backport.
This commit is contained in:
Amaury Denoyelle 2026-04-24 15:58:42 +02:00
parent 85c3f3c1fd
commit 352db46b08
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/stats.c
View File

@ -1057,6 +1057,7 @@ static int cli_parse_dump_stat_file(char **args, char *payload,
ctx->domain = STATS_DOMAIN_PROXY;
ctx->flags |= STAT_F_FMT_FILE;
watcher_init(&ctx->srv_watch, &ctx->obj2, offsetof(struct server, watcher_list));
watcher_init(&ctx->px_watch, &ctx->obj1, offsetof(struct proxy, watcher_list));
return 0;
}