mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-12 18:16:58 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: http-ana: Reset response flags when 1xx messages are handled

Browse Source 
Otherwise, the following final response could inherit of some of these
flags. For instance, because informational responses have no body, the flag
HTTP_MSGF_BODYLESS is set for 1xx messages. If it is not reset, this flag will
be kept for the final response.

One of visible effect of this bug concerns the HTTP compression. When the final
response is preceded by an 1xx message, the compression is not performed. This
was reported in github issue #229.

This patch must be backported to 2.0 and 1.9. Note that the file http_ana.c does
not exist for these branches, the patch must be applied on proto_htx.c instead.
This commit is contained in:
Christopher Faulet 2019-09-03 15:23:54 +02:00
parent 78891c7e71
commit 3499f62b59
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/http_ana.c
View File

@ -1582,7 +1582,6 @@ int http_wait_for_response(struct stream *s, struct channel *rep, int an_bit)
* response which at least looks like HTTP. We have an indicator * response which at least looks like HTTP. We have an indicator
* of each header's length, so we can parse them quickly. * of each header's length, so we can parse them quickly.
*/ */
msg->msg_state = HTTP_MSG_BODY; msg->msg_state = HTTP_MSG_BODY;
BUG_ON(htx_get_first_type(htx) != HTX_BLK_RES_SL); BUG_ON(htx_get_first_type(htx) != HTX_BLK_RES_SL);
sl = http_get_stline(htx); sl = http_get_stline(htx);
@ -1658,6 +1657,7 @@ int http_wait_for_response(struct stream *s, struct channel *rep, int an_bit)
FLT_STRM_CB(s, flt_http_reset(s, msg)); FLT_STRM_CB(s, flt_http_reset(s, msg));
htx->first = channel_htx_fwd_headers(rep, htx); htx->first = channel_htx_fwd_headers(rep, htx);
msg->msg_state = HTTP_MSG_RPBEFORE; msg->msg_state = HTTP_MSG_RPBEFORE;
msg->flags = 0;
txn->status = 0; txn->status = 0;
s->logs.t_data = -1; /* was not a response yet */ s->logs.t_data = -1; /* was not a response yet */
goto next_one; goto next_one;