mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-21 22:01:31 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: tcpcheck: Don't eval custom expect rule on an empty buffer

Browse Source 
The commit a664aa6a6 ("BUG/MINOR: tcpcheck: Be able to expect an empty
response") instroduced a regression for expect rules relying on a custom
function. Indeed, there is no check on the buffer to be sure it is not empty
before calling the custom function. But some of these functions expect to
have data and don't perform any test on the buffer emptiness.

So instead of fixing all custom functions, we just don't eval them if the
buffer is empty.

This patch must be backported but only if the commit above was backported
first.
This commit is contained in:
Christopher Faulet 2023-04-28 14:47:15 +02:00
parent 89aeabff5b
commit 2ebac6a320
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/tcpcheck.c
View File

@ -2047,6 +2047,13 @@ enum tcpcheck_eval_ret tcpcheck_eval_expect(struct check *check, struct tcpcheck
break;
case TCPCHK_EXPECT_CUSTOM:
/* Don't eval custom function if the buffer is empty. It means
* cusstom functions can't expect an empty response. If this
* change, don't forget to change this test and update all
* custom functions.
*/
if (!b_data(&check->bi))
break;
if (expect->custom)
ret = expect->custom(check, rule, last_read);
goto out;