From 2ca616b4e194b4c3a49cf893087c00ce37525992 Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Thu, 27 Mar 2025 17:39:39 +0100 Subject: [PATCH] MINOR: backend: fix comment when killing idle conns Previously, if a server reached its pool-high-count limit, connection were killed on connect_server() when reuse was not possible. However, this is now performed even if reuse is done since the following patch : b3397367dc7cec9e78c62c54efc24d9db5cde2d2 MEDIUM: connections: Kill connections even if we are reusing one. Thus, adjust the related comment to reflect this state. --- src/backend.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/backend.c b/src/backend.c index b897c1551..71a021994 100644 --- a/src/backend.c +++ b/src/backend.c @@ -1723,10 +1723,8 @@ int connect_server(struct stream *s) */ if (ha_used_fds > global.tune.pool_high_count && srv) { + /* We have more FDs than deemed acceptable, attempt to kill an idling connection. */ struct connection *tokill_conn = NULL; - /* We can't reuse a connection, and e have more FDs than deemd - * acceptable, attempt to kill an idling connection - */ /* First, try from our own idle list */ HA_SPIN_LOCK(IDLE_CONNS_LOCK, &idle_conns[tid].idle_conns_lock); if (!LIST_ISEMPTY(&srv->per_thr[tid].idle_conn_list)) {