mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-05 14:47:07 +02:00
Code Issues Projects Releases Wiki Activity

CLEANUP: hlua: get rid of hlua_traceback() security checks

Browse Source 
Thanks to the previous commit, we may now assume that hlua_traceback()
won't LJMP, so it's safe to use it from unprotected environment without
any precautions.
This commit is contained in:
Aurelien DARRAGON 2024-06-04 10:52:44 +02:00
parent 365ee28510
commit 2be94c008e
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/hlua.c
View File

@ -9786,19 +9786,11 @@ static struct task *hlua_event_runner(struct task *task, void *context, unsigned
event_hdl_pause(hlua_sub->sub);
hlua_sub->paused = 1;
if (SET_SAFE_LJMP(hlua_sub->hlua)) {
/* The following Lua call may fail. */
trace = hlua_traceback(hlua_sub->hlua->T, ", ");
/* At this point the execution is safe. */
RESET_SAFE_LJMP(hlua_sub->hlua);
} else {
/* Lua error was raised while fetching lua trace from current ctx */
SEND_ERR(NULL, "Lua event_hdl: unexpected error (memory failure?).\n");
}
trace = hlua_traceback(hlua_sub->hlua->T, ", ");
ha_warning("Lua event_hdl: pausing the subscription because the handler fails "
"to keep up the pace (%u unconsumed events) from %s.\n",
event_hdl_async_equeue_size(&hlua_sub->equeue),
(trace) ? trace : "[unknown]");
event_hdl_async_equeue_size(&hlua_sub->equeue), trace);
}
if (HLUA_IS_RUNNING(hlua_sub->hlua)) {