From 28e295d92c6fcb416ce6077cb2018a48f3c258f3 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Mon, 30 Aug 2021 06:02:47 +0200 Subject: [PATCH] BUILD: globally enable -Wundef As seen in issue #1369, supporting #if with unknown macros can silently hide typos that may result in suboptimal code paths to be used, or even possibly bugs. It looks like our code base does not rely that much on this, so it's worth enabling -Wundef to catch future ones and have them turned to more explicit "#if defined()" or #ifdef. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9a3c8bcd2..d0a7862b6 100644 --- a/Makefile +++ b/Makefile @@ -191,7 +191,7 @@ REG_TEST_SCRIPT=./scripts/run-regtests.sh # We rely on signed integer wraparound on overflow, however clang think it # can do whatever it wants since it's an undefined behavior, so use -fwrapv # to be sure we get the intended behavior. -SPEC_CFLAGS := -Wall -Wextra -Wdeclaration-after-statement +SPEC_CFLAGS := -Wall -Wextra -Wundef -Wdeclaration-after-statement SPEC_CFLAGS += $(call cc-opt-alt,-fwrapv,$(call cc-opt,-fno-strict-overflow)) SPEC_CFLAGS += $(call cc-nowarn,address-of-packed-member) SPEC_CFLAGS += $(call cc-nowarn,unused-label)