mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-21 05:41:26 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: server: fix potential null-deref after previous fix

Browse Source 
A valid build warning was reported in the CI with latest commit b40ce97ecc
("BUG/MEDIUM: server: fix crash after duplicate GUID insertion"). Indeed,
if the first test in the function fails, we branch to the err label
with guid==NULL and will crash there. Let's just test guid before
dereferencing it for freeing.

This needs to be backported to 3.0 as well since the commit above was
meant to go there.
This commit is contained in:
Willy Tarreau 2025-05-22 18:09:12 +02:00
parent b40ce97ecc
commit 28c7a22790
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/guid.c
View File

@ -75,7 +75,8 @@ int guid_insert(enum obj_type *objt, const char *uid, char **errmsg)
return 0; return 0;
err: err:
ha_free(&guid->node.key); if (guid)
ha_free(&guid->node.key);
ha_free(&dup_name); ha_free(&dup_name);
return 1; return 1;
} }