mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-01-31 06:51:11 +01:00
Code Issues Projects Releases Wiki Activity

MINOR: haproxy: always protocol unbind on startup error path

Browse Source 
In haproxy startup, all init error paths after the protocol bind step
cautiously call protocol_unbind_all() before exiting except one that was
conditional. We're not making an exception to the rule and we now properly
call protocol_unbind_all() as well.

No backport needed as this patch is unnoticeable.
This commit is contained in:
Aurelien DARRAGON 2023-01-17 16:30:52 +01:00 committed by Christopher Faulet
parent de63efba5a
commit 28a6d48a60
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/haproxy.c
View File

@ -3381,10 +3381,9 @@ int main(int argc, char **argv)
/* Note: protocol_bind_all() sends an alert when it fails. */
if ((err & ~ERR_WARN) != ERR_NONE) {
ha_alert("[%s.main()] Some protocols failed to start their listeners! Exiting.\n", argv[0]);
if (retry != MAX_START_RETRIES && nb_oldpids) {
protocol_unbind_all(); /* cleanup everything we can */
if (retry != MAX_START_RETRIES && nb_oldpids)
tell_old_pids(SIGTTIN);
}
protocol_unbind_all(); /* cleanup everything we can */
exit(1);
}