mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-25 07:41:36 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: stick-table: Use MAX_SESS_STKCTR as the max track ID during parsing

Browse Source 
During the parsing of the sc-inc-gpc0, sc-inc-gpc1 and sc-inc-gpt1 actions, the
maximum stick table track ID allowed is tested against ACT_ACTION_TRK_SCMAX. It
is the action number and not the maximum number of stick counters. Instead,
MAX_SESS_STKCTR must be used.

This patch must be backported to all stable versions.
This commit is contained in:
Christopher Faulet 2019-12-18 10:25:46 +01:00
parent cb5501327c
commit 28436e23d3
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/stick_table.c
View File

@ -1916,9 +1916,9 @@ static enum act_parse_ret parse_inc_gpc0(const char **args, int *arg, struct pro
return ACT_RET_PRS_ERR; return ACT_RET_PRS_ERR;
} }
if (rule->arg.gpc.sc >= ACT_ACTION_TRK_SCMAX) { if (rule->arg.gpc.sc >= MAX_SESS_STKCTR) {
memprintf(err, "invalid stick table track ID. The max allowed ID is %d", memprintf(err, "invalid stick table track ID. The max allowed ID is %d",
ACT_ACTION_TRK_SCMAX-1); MAX_SESS_STKCTR-1);
return ACT_RET_PRS_ERR; return ACT_RET_PRS_ERR;
} }
} }
@ -1998,9 +1998,9 @@ static enum act_parse_ret parse_inc_gpc1(const char **args, int *arg, struct pro
return ACT_RET_PRS_ERR; return ACT_RET_PRS_ERR;
} }
if (rule->arg.gpc.sc >= ACT_ACTION_TRK_SCMAX) { if (rule->arg.gpc.sc >= MAX_SESS_STKCTR) {
memprintf(err, "invalid stick table track ID. The max allowed ID is %d", memprintf(err, "invalid stick table track ID. The max allowed ID is %d",
ACT_ACTION_TRK_SCMAX-1); MAX_SESS_STKCTR-1);
return ACT_RET_PRS_ERR; return ACT_RET_PRS_ERR;
} }
} }
@ -2107,9 +2107,9 @@ static enum act_parse_ret parse_set_gpt0(const char **args, int *arg, struct pro
return ACT_RET_PRS_ERR; return ACT_RET_PRS_ERR;
} }
if (rule->arg.gpt.sc >= ACT_ACTION_TRK_SCMAX) { if (rule->arg.gpt.sc >= MAX_SESS_STKCTR) {
memprintf(err, "invalid stick table track ID '%s'. The max allowed ID is %d", memprintf(err, "invalid stick table track ID '%s'. The max allowed ID is %d",
args[*arg-1], ACT_ACTION_TRK_SCMAX-1); args[*arg-1], MAX_SESS_STKCTR-1);
return ACT_RET_PRS_ERR; return ACT_RET_PRS_ERR;
} }
} }