mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 23:56:57 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: thread: check stopping thread against local bit and not global one

Browse Source 
Commit ef422ced9 ("MEDIUM: thread: make stopping_threads per-group and add
stopping_tgroups") moved the stopping_threads mask to per-group, but one
test in the loop preserved its global value instead, resulting in stopping
threads never sleeping on stop and eating 100% CPU until all were stopped.

No backport is needed.
This commit is contained in:
Willy Tarreau 2022-07-04 14:07:29 +02:00
parent 291f6ff885
commit 24cfc9f76e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/haproxy.c
View File

@ -2818,7 +2818,7 @@ void run_poll_loop()
if (stopping) { if (stopping) {
/* stop muxes before acknowledging stopping */ /* stop muxes before acknowledging stopping */
if (!(tg_ctx->stopping_threads & tid_bit)) { if (!(tg_ctx->stopping_threads & ti->ltid_bit)) {
task_wakeup(mux_stopping_data[tid].task, TASK_WOKEN_OTHER); task_wakeup(mux_stopping_data[tid].task, TASK_WOKEN_OTHER);
wake = 1; wake = 1;
} }