mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-21 22:01:31 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: backend: fix condition for reuse on mode HTTP

Browse Source 
This commit is a fix/complement to the following one :
08d87b3f49867440f66aee09173c84bf58cbc859
BUG/MEDIUM: backend: never reuse a connection for tcp mode

It fixes the check for the early insertion of backend connections in
the reuse lists if the backend mode is HTTP.

The impact of this bug seems limited because :
- in tcp mode, no insertion is done in the avail list as mux_pt does not
  support multiple streams.
- in http mode, muxes are also responsible to insert backend connections
  in lists in their detach functions. Prior to this fix the reuse rate
  could be slightly inferior.

It can be backported to 2.3.
This commit is contained in:
Amaury Denoyelle 2021-03-05 15:34:56 +01:00
parent d7faa3d6e9
commit 249f0562cf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend.c
View File

@ -1644,7 +1644,7 @@ skip_reuse:
conn_full_close(srv_conn); conn_full_close(srv_conn);
return SF_ERR_INTERNAL; return SF_ERR_INTERNAL;
} }
if (s->be->mode != PR_MODE_HTTP) { if (s->be->mode == PR_MODE_HTTP) {
/* If we're doing http-reuse always, and the connection /* If we're doing http-reuse always, and the connection
* is not private with available streams (an http2 * is not private with available streams (an http2
* connection), add it to the available list, so that * connection), add it to the available list, so that