mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-22 14:21:25 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: contrib/spoa-server: Updating references to free in case of failure

Browse Source 
When we encounter a failure, all previously borrowed references should
be freed. Especially if the program is not failing immediately

This patch must be backported as far as 2.0.
This commit is contained in:
Gilchrist Dadaglo 2020-08-24 19:21:34 +00:00 committed by Christopher Faulet
parent c7d303a0a8
commit 2417ebcc01
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
contrib/spoa_server/ps_python.c
View File

@ -567,6 +567,7 @@ static int ps_python_exec_message(struct worker *w, void *ref, int nargs, struct
key = PY_STRING_FROM_STRING("name");
if (key == NULL) {
Py_DECREF(kw_args);
Py_DECREF(ent);
PyErr_Print();
return 0;
}
@ -632,6 +633,7 @@ static int ps_python_exec_message(struct worker *w, void *ref, int nargs, struct
if (func == NULL) {
Py_DECREF(kw_args);
Py_DECREF(ent);
Py_DECREF(key);
PyErr_Print();
return 0;
}
@ -639,6 +641,7 @@ static int ps_python_exec_message(struct worker *w, void *ref, int nargs, struct
if (ip_dict == NULL) {
Py_DECREF(kw_args);
Py_DECREF(ent);
Py_DECREF(key);
Py_DECREF(func);
PyErr_Print();
return 0;
@ -647,6 +650,7 @@ static int ps_python_exec_message(struct worker *w, void *ref, int nargs, struct
if (ip_name == NULL) {
Py_DECREF(kw_args);
Py_DECREF(ent);
Py_DECREF(key);
Py_DECREF(func);
Py_DECREF(ip_dict);
PyErr_Print();
@ -656,6 +660,7 @@ static int ps_python_exec_message(struct worker *w, void *ref, int nargs, struct
if (ip_value == NULL) {
Py_DECREF(kw_args);
Py_DECREF(ent);
Py_DECREF(key);
Py_DECREF(func);
Py_DECREF(ip_dict);
Py_DECREF(ip_name);
@ -666,6 +671,10 @@ static int ps_python_exec_message(struct worker *w, void *ref, int nargs, struct
Py_DECREF(ip_name);
Py_DECREF(ip_value);
if (ret == -1) {
Py_DECREF(kw_args);
Py_DECREF(ent);
Py_DECREF(key);
Py_DECREF(func);
Py_DECREF(ip_dict);
PyErr_Print();
return 0;