mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-06 23:27:04 +02:00
Code Issues Projects Releases Wiki Activity

MEDIUM: tasks: Don't account a destroyed task as a runned task.

Browse Source 
In process_runnable_tasks(), if the task we're about to run has been
destroyed, and should be free, don't account for it in the number of task
we ran. We're only allowed a maximum number of tasks to run per call to
process_runnable_tasks(), and freeing one shouldn't take the slot of a
valid task.
This commit is contained in:
Olivier Houchard 2019-04-17 22:53:41 +02:00 committed by Willy Tarreau
parent 3f795f76e8
commit 1cfac37b65
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/task.c
View File

@ -388,7 +388,12 @@ void process_runnable_tasks()
t = process(TASK_IS_TASKLET(t) ? NULL : t, ctx, state); t = process(TASK_IS_TASKLET(t) ? NULL : t, ctx, state);
else { else {
__task_free(t); __task_free(t);
t = NULL; curr_task = NULL;
/* We don't want max_processed to be decremented if
* we're just freeing a destroyed task, we should only
* do so if we really ran a task.
*/
continue;
} }
curr_task = NULL; curr_task = NULL;
/* If there is a pending state we have to wake up the task /* If there is a pending state we have to wake up the task