From 1c725aa9cd0e3799d7751381aabc9862bed10aff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Thu, 8 Sep 2022 15:49:37 +0200 Subject: [PATCH] BUG/MINOR: h3: Crash when h3 trace verbosity is "minimal" This was due to a missing check in h3_trace() about the first argument presence (connection) and h3_parse_settings_frm() which calls TRACE_LEAVE() without any argument. Then this argument was dereferenced. Must be backported to 2.6 --- src/h3.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/h3.c b/src/h3.c index 53372c5e3..28656fc71 100644 --- a/src/h3.c +++ b/src/h3.c @@ -1248,6 +1248,9 @@ static void h3_trace(enum trace_level level, uint64_t mask, const struct qcc *qcc = conn ? conn->ctx : NULL; const struct qcs *qcs = a2; + if (!qcc) + return; + if (src->verbosity > H3_VERB_CLEAN) { chunk_appendf(&trace_buf, " : qcc=%p(F)", qcc);