From 19daee654927e6bf1e98860c4698b6a2dfdc8f06 Mon Sep 17 00:00:00 2001 From: William Lallemand Date: Thu, 11 Sep 2025 15:13:23 +0200 Subject: [PATCH] MINOR: ocsp: put internal functions as static ones MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit -Wmissing-prototypes let us check which functions can be made static and is not used elsewhere. rc/ssl_ocsp.c:1079:5: error: no previous prototype for ‘ssl_ocsp_update_insert_after_error’ [-Werror=missing-prototypes] 1079 | int ssl_ocsp_update_insert_after_error(struct certificate_ocsp *ocsp) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/ssl_ocsp.c:1116:6: error: no previous prototype for ‘ocsp_update_response_stline_cb’ [-Werror=missing-prototypes] 1116 | void ocsp_update_response_stline_cb(struct httpclient *hc) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/ssl_ocsp.c:1127:6: error: no previous prototype for ‘ocsp_update_response_headers_cb’ [-Werror=missing-prototypes] 1127 | void ocsp_update_response_headers_cb(struct httpclient *hc) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/ssl_ocsp.c:1138:6: error: no previous prototype for ‘ocsp_update_response_body_cb’ [-Werror=missing-prototypes] 1138 | void ocsp_update_response_body_cb(struct httpclient *hc) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/ssl_ocsp.c:1149:6: error: no previous prototype for ‘ocsp_update_response_end_cb’ [-Werror=missing-prototypes] 1149 | void ocsp_update_response_end_cb(struct httpclient *hc) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ src/ssl_ocsp.c:2095:5: error: no previous prototype for ‘ocsp_update_postparser_init’ [-Werror=missing-prototypes] 2095 | int ocsp_update_postparser_init() | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ --- src/ssl_ocsp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/ssl_ocsp.c b/src/ssl_ocsp.c index 64947bf05..c2fe8d105 100644 --- a/src/ssl_ocsp.c +++ b/src/ssl_ocsp.c @@ -1076,7 +1076,7 @@ int ssl_ocsp_update_insert(struct certificate_ocsp *ocsp) * for instance). This ensures that the entry does not get reinserted at the * beginning of the tree every time. */ -int ssl_ocsp_update_insert_after_error(struct certificate_ocsp *ocsp) +static int ssl_ocsp_update_insert_after_error(struct certificate_ocsp *ocsp) { int replay_delay = 0; @@ -1113,7 +1113,7 @@ int ssl_ocsp_update_insert_after_error(struct certificate_ocsp *ocsp) return 0; } -void ocsp_update_response_stline_cb(struct httpclient *hc) +static void ocsp_update_response_stline_cb(struct httpclient *hc) { struct task *task = hc->caller; @@ -1124,7 +1124,7 @@ void ocsp_update_response_stline_cb(struct httpclient *hc) task_wakeup(task, TASK_WOKEN_MSG); } -void ocsp_update_response_headers_cb(struct httpclient *hc) +static void ocsp_update_response_headers_cb(struct httpclient *hc) { struct task *task = hc->caller; @@ -1135,7 +1135,7 @@ void ocsp_update_response_headers_cb(struct httpclient *hc) task_wakeup(task, TASK_WOKEN_MSG); } -void ocsp_update_response_body_cb(struct httpclient *hc) +static void ocsp_update_response_body_cb(struct httpclient *hc) { struct task *task = hc->caller; @@ -1146,7 +1146,7 @@ void ocsp_update_response_body_cb(struct httpclient *hc) task_wakeup(task, TASK_WOKEN_MSG); } -void ocsp_update_response_end_cb(struct httpclient *hc) +static void ocsp_update_response_end_cb(struct httpclient *hc) { struct task *task = hc->caller; @@ -2092,7 +2092,7 @@ int ocsp_update_init(void *value, char *buf, struct ckch_data *d, int cli, const return ret; } -int ocsp_update_postparser_init() +static int ocsp_update_postparser_init() { int ret = 0; char *err = NULL;