mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-09-23 14:51:27 +02:00
BUG/MINOR: http-act: make release_http_redir() more robust
Since commit dd7e6c6dc ("BUG/MINOR: http-rules: completely free incorrect TCP rules on error") free_act_rule() is called on some error paths, and one of them involves incomplete redirect rules that may cause a crash if the rule wasn't yet initialized, as shown in this config snippet: frontend ft mode http bind *:8001 http-request redirect location /%[always_false,sdbm] Let's simply make release_http_redir() more robust against null redirect rules. No backport needed since it seems that the only way to trigger this was the extra check above that was merged during 2.6-dev.
This commit is contained in:
parent
643f1b7bef
commit
16daaf319c
@ -1760,6 +1760,9 @@ static void release_http_redir(struct act_rule *rule)
|
|||||||
struct redirect_rule *redir;
|
struct redirect_rule *redir;
|
||||||
|
|
||||||
redir = rule->arg.redir;
|
redir = rule->arg.redir;
|
||||||
|
if (!redir)
|
||||||
|
return;
|
||||||
|
|
||||||
LIST_DELETE(&redir->list);
|
LIST_DELETE(&redir->list);
|
||||||
if (redir->cond) {
|
if (redir->cond) {
|
||||||
prune_acl_cond(redir->cond);
|
prune_acl_cond(redir->cond);
|
||||||
|
Loading…
x
Reference in New Issue
Block a user