mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-02-11 20:31:11 +01:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: hlua: fix reference leak in hlua_post_init_state()

Browse Source 
hlua init function references were not released during
hlua_post_init_state().

Hopefully, this function is only used during startup so the resulting
leak is not a big deal.
Since each init lua function runs precisely once, it is safe to release
the ref as soon as the function is restored on the stack.

This could be backported to every stable versions.
Please note that this commit depends on "MINOR: hlua: add simple hlua reference handling API"
This commit is contained in:
Aurelien DARRAGON 2023-03-20 16:29:55 +01:00 committed by Christopher Faulet
parent be58d6683c
commit 16d047b615
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hlua.c
View File

@ -11857,6 +11857,10 @@ int hlua_post_init_state(lua_State *L)
list_for_each_entry(init, &hlua_init_functions[hlua_state_id], l) {
lua_rawgeti(L, LUA_REGISTRYINDEX, init->function_ref);
/* function ref should be released right away since it was pushed
* on the stack and will not be used anymore
*/
hlua_unref(L, init->function_ref);
#if defined(LUA_VERSION_NUM) && LUA_VERSION_NUM >= 504
ret = lua_resume(L, L, 0, &nres);