mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-06 23:27:04 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: servers: Don't attempt to destroy idle connections if disabled.

Browse Source 
In connect_server(), when deciding if we should attempt to remove idle
connections, because we have to many file descriptors opened, don't attempt
to do so if idle connection pool is disabled (with pool-max-conn 0), as
if it is, srv->idle_orphan_conns won't even be allocated, and trying to
dereference it will cause a crash.
This commit is contained in:
Olivier Houchard 2019-06-05 13:55:01 +02:00 committed by Olivier Houchard
parent 344e94816c
commit 14fcc2ebcc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend.c
View File

@ -1335,8 +1335,8 @@ int connect_server(struct stream *s)
reuse = 0;
}
}
if ((!reuse || (srv_conn && !(srv_conn->flags & CO_FL_CONNECTED)))
&& ha_used_fds > global.tune.pool_high_count) {
if (((!reuse || (srv_conn && !(srv_conn->flags & CO_FL_CONNECTED)))
&& ha_used_fds > global.tune.pool_high_count) && srv->idle_orphan_conns) {
struct connection *tokill_conn;
/* We can't reuse a connection, and e have more FDs than deemd